2009/11/18 Kelly O'Hair <[email protected]>: > > Need a reviewer. > > The jhat change is from [email protected]. I wasn't able to > come up with a testcase for that change. > > The other two just fix a couple of broken tests and remove them from > the ProblemList. > > 6892742: Improve root set used by jhat > 6902323: Fix testcase sun/tools/native2ascii/NativeErrors.java > 6902325: Fix testcase sun/tools/jhat/HatHeapDump1Test.java > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jhat-6892742/webrev/ > > -kto > > >
Pretty much the same fix for the JHat issue was filed by one of our Red Hat interns in March: http://bugs.openjdk.java.net/show_bug.cgi?id=100026 but sadly completely ignored by anyone at Sun (at least it seems so from the bug report). This is one reason why I've tended to not bother with the OpenJDK bug system... Anyway, coming to merge that with the version now in OpenJDK6 version I found that the upstream doesn't update the comment. So perhaps we could push: http://cr.openjdk.java.net/~andrew/jhat/webrev.01/ given a bug ID for this small change. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
