Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

[Daniel D. Daugherty]

Thanks for the review!  I did a merge with HSX-17 this AM and that went very smoothly so I'm testing those bits right now. I'm hoping to hear from Vasanth today, but he doesn't appear to have an OpenJDK id so I can't list him as a reviewer; I have listed him as a contributor. I'm also hoping to hear from Kelly since my Makefile tweaks were in stuff he knows... Dan Tom Rodriguez wrote: This looks good to me. Thanks for your thorough work on this. tom On Jan 11, 2010, at 11:28 AM, Daniel D. Daugherty wrote: Second call for this code review request. Dan Daniel D. Daugherty wrote: Greetings, The folks at AMD Labs have been kind enough to provide an extension to the JVM/TI CompileMethodLoad event in order to provide additional information about in-lining. This extension uses the existing (but previously unused) compile_info paramter: http://java.sun.com/javase/6/docs/platform/jvmti/jvmti.html#CompiledMethodLoad Vasanth and company provided the HotSpot code changes and the original demo program. I just did the Makefile changes to export the new jvmticmlr.h file in the HotSpot repo and the integration of the demo program into JAVA_HOME/demo/jvmti in the JDK repo. Here is the webrev for the OpenJDK6 version of the changes: http://cr.openjdk.java.net/~dcubed/6580131-webrev/0/ The OpenJDK7 version of these changes are not expected to be very different from this version. For the Sun folks, the CCC request for adding the jvmticmlr.h is almost final. I'm waiting for the VM-SQE team to agree that the latest version addresses their review concerns, but I think the St Petersburg team is on holiday at the moment. Any reviews are appreciated. Dan