I'll work on fixing that right now.
Is there a Twiki available about working on the test suites
or requesting test modification?
Fred
On 03/18/10 04:11 PM, Karen Kinnear wrote:
Frederic,
Can you please file and fix a bug so that the test suite expects the new
probes? Or work with
the test team to add the fix?
In the RT_Baseline nightly run last night we had a failure:
http://sqeweb.sfbay.sun.com/nfs/results/vm/gtee/JDK7/NIGHTLY/VM/2010-03-17/RT_Baseline/vm/solaris-amd64/server/mixed/solaris-amd64_server_mixed_vm.dtrace.testlist/ResultDir/hotspot001/hotspot001.log
Looks like the ${TESTBASE}/src/dtrace/share/provider_probes_checker.pl has
a hardcoded list of expected probes - so I think you would just need to
add these new
ones to the list.
I don't know how you modify the test to know the new ones are available
after a
certain version of hotspot though or if it would be appropriate to
change any version capability
information when adding these changes - I'll let Keith and Dan answer
that one.
thanks,
Karen
p.s. thank you for the new probes - they will be very useful.
On Mar 17, 2010, at 12:07 PM, [email protected] wrote:
Changeset: e392695de029
Author: fparain
Date: 2010-03-17 11:01 +0100
URL:
http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e392695de029
6935224: Adding new DTrace probes to work with Palantir
Summary: Adding probes related to thread scheduling and class
initialization
Reviewed-by: kamg, never
! src/os/solaris/dtrace/hotspot.d
! src/os/solaris/vm/attachListener_solaris.cpp
! src/share/vm/includeDB_core
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/unsafe.cpp
! src/share/vm/runtime/vmThread.cpp
! src/share/vm/services/dtraceAttacher.cpp
! src/share/vm/services/dtraceAttacher.hpp
--
Frederic Parain - Sun Microsystems
180, av. de l'Europe, ZIRST de Montbonnot
38334 Saint Ismier, FRANCE
Phone: +33 4 76 18 81 17
Email: [email protected]
