Hi Alan,
On 1 Jun 2010, at 11:21, Alan Bateman wrote:
Looks okay to me. There are a couple of /tmp references left in the
comments:
Linux:
268 // found it looks in /tmp.
276 // Not found, so try /tmp
Solaris:
196 // directory or /tmp.
222 // target VM's working directory (or /tmp), and the SIGQUIT
handler checks
Cheers,
David
Thanks David. I'll fix up these comments before pushing this.
There is also:
hotspot/src/os/solaris/vm/attachListener_solaris.cpp:590:// or /tmp
then this is the trigger to start the attach mechanism
hotspot/src/os/linux/vm/attachListener_linux.cpp:459:// or /tmp then
this is the trigger to start the attach mechanism
but this is in different repository, so I am not sure if you can
change these comments in one commit together with above changes.
Bye,
--
Tomas Hurka <mailto:[email protected]>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic
