On 6/11/2010 4:41 PM, Martin Buchholz wrote:
On Fri, Jun 11, 2010 at 14:46, Daniel D. Daugherty
<[email protected]> wrote:
Jeremy,
I'm definitely interested in learning about your approach to this issue.
Here's the patch against openjdk6 by Jeremy.
http://cr.openjdk.java.net/~martin/WeakLogger-jeremymanson.patch
(It would take a bit of merging to port to openjdk7)
Feel free to take anything from our change.
Apologies for the perforce-isms.
Martin
Jeremy and Martin,
Thanks for the proposed fix. A couple of questions:
- This changeset is private to Google right now, correct? As in
it hasn't made it into OpenJDK6 yet.
- Do you plan on pushing this changeset to OpenJDK6?
- What kind of testing has been done on it?
Thanks for the offer for the code. I'll start wading through the
diffs today. Because this is an escalated issue, I will likely
be taking just the code and comments directly related to the
problem at hand. The JavaDoc fixes, even though they are useful,
will have to wait for a different changeset.
Thanks for jumping in on this thread.
Dan
