Folks, We missed the T&L JDK7-B100 cutoff which was Monday @ 1800 PT. That means this fix will hit the various update releases before it hits JDK7. At this point, I'm really going to need those re-reviews in order to make a good case that this fix can go into an update without bake time in JDK7.
Dan On 6/21/2010 3:29 PM, Daniel D. Daugherty wrote:
David H. and Alan B., Since you two were first round code reviewers, it would be good to hear from you guys on the second round. Jeremy, It would also be good to hear from you since you had also fixed this bug in Google's code base. At this point, I've heard from Eamonn McManus and Tony Printezis on the second round so I have my required two reviewers, but... Dan On 6/18/2010 1:25 PM, Daniel D. Daugherty wrote:Greetings, I have a new version of my fix for the WeakReference leak in the Logging API done. This version uses ReferenceQueues; thanks to Eamonn McManus, Jeremy Manson and Tony Printezis for their insights on using ReferenceQueues. Here's a pointer to Tony's paper for background info: http://java.sun.com/developer/technicalArticles/javase/finalization/ This version also has limits on the number of dead Loggers that are cleaned up per call; thanks to Alan Bateman for politely pushing me in that direction. The webrev is again relative to OpenJDK7, but the bug is escalated so the fix will be backported to the JDK6-Update train. So again, I'll need a minimum of two code reviewers. Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/6942989-webrev/1/ Thanks, in advance, for any reviews. Dan
