Looks good. One minor suggestion - you may consider changing the following warning message to something like "Could not get status information on file ".

1357     struct stat statbuf;
1358     int ret_code = ::stat(filename, &statbuf);
1359     if (ret_code == OS_ERR) {
1360       if (PrintMiscellaneous && Verbose) {
1361         warning("could not stat file %s: %d\n", filename, ret_code);
1362       }


Thanks,
Poonam


On 2/16/2011 6:19 AM, Daniel D. Daugherty wrote:
I need a Runtime team reviewer!

Dan

On 2/14/2011 4:02 PM, Daniel D. Daugherty wrote:
Greetings,

I have a fix for the following jvmstat/jps bug:

6954420: 2/4 jps shows "process information unavailable" sometimes
Summary: Make sure the backing store file is flushed in create_sharedmem_resources() and get_user_name_slow() no longer checks the size of the backing store file.
Reviewed-by:

Here is the URL for the webrev:

   http://cr.openjdk.java.net/~dcubed/6954420-webrev/0/

Thanks, in advance, for any reviews.

Dan



Reply via email to