On 4/12/2011 2:23 PM, Dmitry
wrote:
Dan,
test/com/sun/tools/attach/BasicTests.java
We don't break output into lines explicitly (i.e. no \n inside) is it
expected?
Yes. Kelly wanted the INFO output on a single line.
test/com/sun/tools/attach/BasicTests.sh
+echo "INFO: Test 2 will cause error messages about SilverBullet.jar" \
+ "and an agent failing to start."
missed space after SilverBullet.jar
same problem on line below
Nope. Since this is shell, those are two separate "words" and
will be separates by a single space.
Otherwise looks good - thumb up ;).
Thanks!
Dan
-Dmitry
On 2011-04-13 00:13, Daniel D. Daugherty wrote:
Updated BasicTests.java and BasicTests.sh to output
single "INFO" lines:
http://cr.openjdk.java.net/~dcubed/7035555-webrev/1/
Better?
Dan
On 4/12/2011 12:21 PM, Daniel D. Daugherty wrote:
I could do that, but I was trying to be "nice" formatting wise.
Dan
On 4/12/2011 12:19 PM, Kelly O'Hair wrote:
Why the multiple println() lines? Why not just one "INFO:" message,
who gives a rip how long it is?
-kto
On Apr 12, 2011, at 8:12 AM, Daniel D. Daugherty wrote:
Greetings,
I have minor fixes to an Attach On Demand (AOD) test that I'd
like to get into T&L snapshot for OpenJDK7-B140 (next week).
Here is my proposed changeset comment:
7035555: 4/4 attach/BasicTests.sh needs another tweak for Cygwin
Summary: Test needs to properly detect missing
AgentInitializationException. Clarify when exceptions
are expected. Another Cygwin tweak.
Yes, this bug started out as a tweak for Cygwin and then I
discovered and fixed the other small issues.
Here is the URL to the webrev:
http://cr.openjdk.java.net/~dcubed/7035555-webrev/0/
I've run the fix through JPRT testing and I ran into an existing
intermittent failure:
6461635 4/3 BasicTests.sh test fails intermittently.
I've checked nightly testing and 6461635 makes a periodic
appearance across all platforms.
Thanks, in advance, for any comments.
Dan
