Hi Paul, I've used 7117389 and added a few manageable flags in globals_ext.hpp in my local experiment builds, and they all seem to work fine (jinfo -flag can correctly query and set the new flags; didn't try JConsole).
Does 7124880 change any behaviors of the manageable flags? Or is it just for explicitness that management.cpp includes globals.hpp? Regards, Kris Mok On Tue, Dec 20, 2011 at 1:24 AM, Paul Hohensee <paul.hohen...@oracle.com>wrote: > The framework implemented for > > 7117389: Add a framework for vendor-specific command line switch > extensions to Hotspot > > did not include support for vendor-specific manageable-by-JMX switches. > This change adds new methods Flag::is_external_ext() and > Flag::is_writeable_ext() that > return false, and uses them in Flag::is_external() and > Flag::is_writeable(). Somewhat > relatedly, management.cpp didn't include globals.hpp, even though it uses > Flag methods. > I added globals.hpp to its #include list for completeness, even though it > was being > included indirectly. > > Webrev here > > http://cr.openjdk.java.net/~**phh/7122880.00/<http://cr.openjdk.java.net/~phh/7122880.00/> > > Thanks, > > Paul > >
