Looks good.
Paul
On 1/6/12 7:17 AM, Frederic Parain wrote:
Thanks for the review,
On 01/ 5/12 07:32 PM, Paul Hohensee wrote:
In globals.hpp, you might take this opportunity to get rid of the
default value for the withComments argument to printFlags.
Done.
In diagnosticCommand.hpp, there's a few places with blanks
between parens where the blanks should go away, vis.
static const char* name( ) { ... }
Fixed.
In diagnosticCommand.cpp, in PrintSystemProperties::execute(),
the arguments to call_static don't seem to line up. Possibly a
webrev artifact.
It wasn't a webrev artifact, it's fixed now.
New webrev: http://cr.openjdk.java.net/~fparain/7120511/webrev.01/
Thank you,
Fred
