On 1/13/2012 12:03 PM, Kurchi Hazra wrote:
Updated webrev: http://cr.openjdk.java.net/~khazra/7117570/webrev.07/
I re-reviewed Agent.java and the files I had comments with.
GarbageCollectorImpl.java L76: nit - needs a space between "for" and "(" SnmpNamedListTableCache.java L215: I assume the unchecked suppressed warning is gone and this annotation can be removed, right? L225: the cast "(List<?>)" isn't needed. SnmpListTableCache.java L107: this cast "(Object)" shouldn't be needed.
Looks good. When Dmitry agrees with the change, I can sponsor this changeset and push it for you.
Thank you for doing the warning cleanup in this area. Mandy