On 04/13/2012 07:21 PM, Tom Rodriguez wrote:
It's unfortunate that we can't use sizeof(_thread_id) in a static context.

Agreed!


In osThread_solaris.hpp there's a type name mismatch.

+   static size_t thread_id_size()   { return sizeof(pid_t); }
     thread_t thread_id() const       { return _thread_id; }

Otherwise it looks good.

Thanks for catching that one, I'll change it and submit.

/R


tom

On Apr 13, 2012, at 6:49 AM, Rickard Bäckman wrote:

Thank you Staffan,

still need one Reviewer, any takers?

Thanks
/R

On 04/13/2012 11:21 AM, Staffan Larsen wrote:
Looks good.

/Staffan

On 11 apr 2012, at 14:55, Rickard Bäckman wrote:

Hi all,

can I get reviews for the following change where we add support for intrinsics 
for a couple of methods specified by the tracing framework?

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160570

http://cr.openjdk.java.net/~rbackman/7160570/webrev

Thank you.
/R




Reply via email to