On 8/05/2012 5:48 PM, Nils Loodin wrote:
Can I get a Reviewer to look at this? Does no reviewer care about SA? :)
Don't have a Mac or know inner details of BSD/OSX ;-)
Changes to x86_64 seem okay though it seems a little odd to accept amd64
but report the only valid values are x86/x86_64.
Also I'm a little confused ... some of this is not BSD/OSX specific and
we should already support x86_64 for Linux/Solaris shouldn't we? (I
guess not but why not? we don't use amd64 on any platform any more).
David
Regards
Nils Loodin
On May 4, 2012, at 13:01 , Nils Loodin wrote:
Built it and connected to a running java process and ran some commands.
I see other issues, but the connecting part actually works now.
This will probably open up more bugs.
/Nils Loodin
On May 4, 2012, at 12:05 , Staffan Larsen wrote:
Looks good. I can sponsor the push.
What kind of testing have you done?
/Staffan
On 4 maj 2012, at 11:28, Nils Loodin wrote:
looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using
nowadays.
http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/
Need reviews and a sponsor!
Regards,
Nils Loodin
