Thumbs up!
Thanks for including a sample failure and a sample success.
agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java
No comments.
Dan
On 4/23/12 9:05 PM, Krystal Mok wrote:
Hi all,
Could I get a review for this patch, please?
Regards,
Kris
On Thu, Apr 19, 2012 at 3:55 PM, Krystal Mok <[email protected]
<mailto:[email protected]>> wrote:
Thanks, Staffan :-)
- Kris
On Thu, Apr 19, 2012 at 3:53 PM, Staffan Larsen
<[email protected] <mailto:[email protected]>> wrote:
Hi Kris,
This fix looks good to me. I've created a bug for
you: 7162726. I'll be happy to push the fix for you once the
review is done (need one Reviewer).
Thanks,
/Staffan
On 19 apr 2012, at 06:49, Krystal Mok wrote:
Hi all,
There seems to be a bug in the filtering logic of visible
local variable in Serviceability Agent's JSJavaFrame.
I've made a patch here: [1]. The diff is against tip of
jdk8/jdk8/hotspot
An example of running CLHSDB before and after applying the
patch is avaiable [2].
Could anyone please review this for me?
- Kris
[1]: https://gist.github.com/2418558#file_getlocal.patch
[2]: https://gist.github.com/2418558#file_clhsdb_session2
