In agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java there are some commented out system.out.printlns that perhaps should be removed. Otherwise I guess the changes looks good, but it's too bad that the current design of SA requires so much code duplication…
Regards, Nils Loodin On May 31, 2012, at 14:49 , Nils Loodin wrote: > > Also forwarding to serviceability dev.. > > /Nisse > > Begin forwarded message: > >> From: Poonam Bajaj <poonam.ba...@oracle.com> >> Subject: Re: JPSE-J2SE Code Review Request-6310967-jdk160-pool_b01#4592, due >> by 5/30/12_12:53_AM >> Date: May 31, 2012 5:46:27 GMT+02:00 >> To: nils.loo...@oracle.com, yumin...@oracle.com >> >> Hi Nils, Yumin, >> >> Could you please review these code changes. >> >> Thanks, >> Poonam >> >> On 5/25/2012 1:24 PM, poonam.ba...@oracle.com wrote: >>> >>> >>> poonam.ba...@oracle.com's following code review request has been sent to >>> yumin...@oracle.com,nils.loo...@oracle.com. >>> Please review the code before 5/30/12_12:53_AM. >>> >>> If yumin...@oracle.com,nils.loo...@oracle.com can not meet the review >>> timeline, please contact >>> poonam.ba...@oracle.com to negotiate for an appropriate time-frame. >>> >>> http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4592 >>> >>> webrev: >>> http://jpsesvr.us.oracle.com:8080/ctetools/html/ViewDetail.jsp?index=4592 >>> ====================================== >>> Escalation ID : 13503116 >>> Escalation Synopsis : JSTACK -M RETURNS SUN.JVM.HOTSPOT.DEBUGGER.UNALIGNED >>> EXCEPTION FOR SOME THREAD >>> Bug ID : 6310967 >>> Bug Synopsis : SA: jstack -m produce failures in output >>> >>> Request Engineer : poonam.ba...@oracle.com >>> Code Reviewer : yumin...@oracle.com,nils.loo...@oracle.com >>> Parent Workspace : /net/nightsvr/export4/integration/6u34/hotspot >>> Child Workspace : /net/jdk/export/jpse06/poonam/ws/6u34_6310967/hotspot >>> Platforms : Shared Code >>> Version : JDK6-pool_b01 >>> Fix information : New Fix >>> Severity : normal - level 1 >>> Submit Date : 5/25/12 12:53 AM >>> >>> Problem and Fix Description : >>> Problem: jstack -m fails with UnalignedAddressException >>> >>> The problem is that while finding the caller frame of a frame in sender() >>> method, we don't check the validity of the frame pointer (rbp / ebp). >>> >>> These changes add a simple check that the frame pointer(rbp) should be a >>> valid pointer on the stack by making sure that it should not be less than >>> the stack pointer(rsp). >>> >>> These changes are for jdk6. >>> >>> Modified source lists : >>> agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/sparc/LinuxSPARCCFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/x86/LinuxX86CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcCFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java >>> >>> Approve Info : >>> >>> >>> Putback info : >>> ====================================== >>> This message is autogenerated by code management tool. >> >> -- >> Best regards, Poonam >> <oracle_sig_logo.gif> >> Poonam Bajaj | Principal Member of Technical Staff >> Phone: +91 80 67283726 | Mobile: +91 9844511366 >> Oracle JVM Sustaining Engineering >> >> ORACLE India Bangalore >> <green-for-email-sig_0.gif> Oracle is committed to developing practices and >> products that help protect the environment >> >
