Tim,
Great to have the original author look at the test(s). Don't want to
break anything.
Mandy,
Thanks for taking the time to do another review. This should of course been
part of the original fix. Mea culpa.
Michael,
Good, then we will have some solid checks that the translation works as
expected going forward!
/Erik
Mandy Chung skrev 2012-05-31 03:15:
Looks good. Sorry for not catching the test issue during the review
for 7017818.
Mandy
On 5/30/2012 4:40 AM, Erik Gahlin wrote:
Hi,
Could you please review 7172176, which is a test fix for 7017818 -
JConsoleResources.java cannot be handled by translation team.
Webrev:
http://cr.openjdk.java.net/~egahlin/7172176_01/
Changes:
- Removed the ImmutableRequest.java and ImmutableRequest.sh since the
JConsoleResources class was refactored away with 7017818.
- Removed hard-wired resource bundle keys in ResourceCheckTest.java,
the keys
are now looked up by reflection on the Messages class. The test also
checks there is one-to-one mapping between reource bundle keys and
the constants available in the Message class.
Michael,
I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/
ProblemList.txt. This means the test will break once the translated
files
will be checked in. Unused messages were sent for translation and they
need to be removed.
Are you ok with that?
Thanks!
Erik
