On 7/18/12 12:03 PM, Mark Wielaard wrote:
On Wed, 2012-07-18 at 11:41 -0700, [email protected] wrote:
On 7/18/12 10:23 AM, Mark Wielaard wrote:
On Wed, Jul 18, 2012 at 10:10:43AM -0700, [email protected] wrote:
This work includes investigation to find proper linux machine,
installation of the systemTap, building and testing, and so,
needs some engineering resources.
I can do that, the patch has already been included in various
distros so it shouldn't be a problem. Just let me know what you
need.
Also, it needs a new unit test and submitting a CCC request.
You only can help by providing a test for the patch.
Sure, I was looking for existing dtrace tests to see if I can
match them. Do you have a good example I can follow?
Normally a dtrace test needs 4 parts:
java test program, d-script, shell script and README
How/Where does this hook into the openjdk testsuite?
Currently, it does not.
d-scripts obviously aren't supported on GNU/Linux, so that part seems
not easily reusable. And the functionality that is being added is just
for the probe points, not for anything higher level. Detecting the sdt
Ok. It is good to know.
probes are there can be done with anything that can read elf notes,
stap, gdb, readelf, etc. It seems none of these are used yet in the
openjdk/hotspot/test suite (there seems to be only 1 lonely
servicability test), but I can try to hook something up.
That would be nice.
Is it all jtreg based?
The SQE testbase is used for the dtrace tests which is not jtreg based.
I do not need yet the test in any existing format.
What I need is a manual test that consists of whatever you add there.
It must be suitable to run testing steps manually and check if the
feature works.
I'll convert it to the jtreg format if needed.
How do you check in the testsuite which features are enabled in a
build?
This is one of the questions that has to be resolved.
The test has to be reliable and finish gracefully if the feature is not
enabled.
Thanks,
Serguei
Thanks,
Mark
