On 18/08/2012 19:09, Mandy Chung wrote:
Alan,

Looks good to me. It's good to add a test to cover these methods (thanks). You might want to add the case when SecurityManager is enabled. Your change doesn't affect the permission check and I'm fine with what you have.

Mandy
Thanks for looking at this. Tests using a security manager would require a bit more work and slightly beyond the scope of the changes but let me see if I find time before pushing this change.

-Alan.

Reply via email to