On 30/08/2012 5:50 PM, Staffan Larsen wrote:
The patch looks good to me and I can sponsor the push to JDK8-TL.
However, you need a review from an official Reviewer as well.
Reviewed.
Any way we can get a regression test too?
David
-----
BTW, I suggest we remove the confusing comment in
Java_com_sun_management_OperatingSystem_getTotalPhysicalMemorySize()
while we are at it.
/Staffan
On 30 aug 2012, at 09:18, Dmytro Sheyko <dmytro_she...@hotmail.com
<mailto:dmytro_she...@hotmail.com>> wrote:
Hi,
Could you please review the patch and apply it if it's correct?
https://bugs.openjdk.java.net/show_bug.cgi?id=100077
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6853676
Thanks,
Dmytro
> Date: Wed, 2 Feb 2011 20:09:59 +1000
> From:david.hol...@oracle.com <mailto:david.hol...@oracle.com>
> To:alan.bate...@oracle.com <mailto:alan.bate...@oracle.com>
> CC:dmytro_she...@hotmail.com <mailto:dmytro_she...@hotmail.com>;
serviceability-dev@openjdk.java.net
<mailto:serviceability-dev@openjdk.java.net>;hotspot-...@openjdk.java.net
<mailto:hotspot-...@openjdk.java.net>;core-libs-...@openjdk.java.net
<mailto:core-libs-...@openjdk.java.net>;jmx-...@openjdk.java.net
<mailto:jmx-...@openjdk.java.net>
> Subject: Re: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize
has incorrect value
>
> Alan Bateman said the following on 02/02/11 20:05:
> > David Holmes wrote:
> >> It looks like this was actually fixed under 6840305 back in July
2009:
> >>
> >> http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8c79517a9300
> >>
> >> This CR was not updated however.
> >>
> >> Does the problem still exist?
> >>
> >> David Holmes
> > I think this is separate and 6853676 is about
> > com.sun.management.OperatingSystemMXBean. The code for that is in jdk
> > repo in src/windows/native/com/sun/management. It should be using
> > GlobalMemoryStatusEx rather than GlobalMemoryStatus.
>
> Thanks Alan, the comments in 6853676 led me astray.
>
> As a P4 it looks like this has just slipped through the cracks.
>
> David
>
>
> > Dmytro - to your question, serviceability-dev is the right place to
> > bring it.
> >
> > -Alan
