On 9/12/2012 1:33 AM, Alan Bateman wrote:
This looks good to me. A minor point but LockInfo should have an @since 1.8 to make it clear that the from( CompositeData) is new. Also as LazyCompositeData is serializable then you may wish to add a serialVersionUID to LockInfoCompositeData too (I see the other implementations already do this).


Thanks for catching that.  I should have caught them myself :)

Updated webrev:
   http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193302/webrev.01/

FYI. I have filed a CR for the JMX com.sun.jmx.DefaultMXBeanMappingFactory change: 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties

Mandy

Reply via email to