This change broke the usage of previously built versions of hsdis. I filed a bug for it:
8000489: older builds of hsdis don't work anymore after 6879063 Yumin, I assigned the bug to you. Could you please take care of it? -- Chris On Aug 27, 2012, at 2:07 PM, Yumin Qi <yumin...@oracle.com> wrote: > Hi, all > > Can I have you code review of > 6879063: SA should use hsdis for disassembly > > http://cr.openjdk.java.net/~minqi/6879063 > > The SA has Java based disassemblers for x86 and sparc but amd64. Instead > of porting to amd64 we should switch over to using hsdis for it like the JVM > does. This requires a new entry point into hsdis, > decode_instructions_virtual, which separates the address of the code being > disassembled from the buffer containing the code. The existing uses of > decode_instructions have been updated to use the new interface and SA > Disassembler has Java native methods that call into hsdis and call back up to > Java to perform the disassembly. Also changed makefile for hsdis build for > both(i386/amd64). > > All the old disassembler logic was deleted since it's incompatible with the > new disassembly interface. Also deleted are dbx based SA interface and few > other dead files. > > Tested by dumping full assembly from core files. > > Reviewed-by: > Contributed-by: Tom R (never) > > Thanks > Yumin Qi >
