On 01/04/2013 11:37 PM, Kelly O'Hair wrote: > > On Dec 31, 2012, at 2:40 AM, Jaroslav Bachorik wrote: > >> Looking for a review and a sponsor. >> >> Webrev at: >> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.00/test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh.sdiff.html >> >> JPRT run on windows targets: >> http://sthjprt.se.oracle.com/archives/2012/12/2012-12-28-123054.jbachorik.openjdk8-tl//JobStatus.txt >> >> The issue is about a new test failing when run on windows machines. It >> seems that the cygwin really does not like removing a non-existent file >> - to the extent of hanging the script indefinitely. > > I suspect it is not hanging because it does not exist, but that some other > windows process has it's hands on it. > This is the stdout file from the server being started up right? > Could the server from a previous test run be still running?
Exactly. Amy confirmed this and provided a patch which resolves the hanging problem. The update patch is at http://cr.openjdk.java.net/~jbachorik/8005472/webrev.01 -JB- > > Maybe a better answer might be to make the filename a bit more unique, like > maybe foobar.$$ ??? > >> >> The patch adds a pre-check for the existence of the file to be removed. >> It does not change the test in any other way. > > This test doesn't make much sense to me. rm should never hang on a non > existent file. > > And by the way, it might be a good idea for scripts to always use 'rm -f', > which is what the default is for Makefiles with $(RM) > > > -kto > >> >> >> Thanks, >> >> -JB- >
