Thanks for doing this Yumin! I tried to apply you patch and run it, but I can't get SA to open a core file. You can see the exception I get below. Is there some kind of setup I need to do? This is against a jvmg build of Hotspot.
I also noticed that you forgot to update BugSpotAgent.java with the same changes as in HotspotAgent.java. This makes the jstack tool fail. I will look at the changes more closely. Thanks, /Staffan Opening core file, please wait... Unable to open core file /cores/core.79028: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) hsdb> Input stream closed. On 17 jan 2013, at 22:23, Yumin Qi <yumin...@oracle.com> wrote: > Hi, > > Please review for the changes for SA to read core file on Mac OS X, this > is feature is not implemented on previous releases. > This change made for SA to work on core file on Darwin, but still some > function not fixed, such as 'pstack'. This is intended to integrate into 8. > > http://cr.openjdk.java.net/~minqi/8003348/ > > Please take some time since the code change is a little bigger. > > Thanks very much > Yumin