Mandy,
The test designed to leave as much as possible to JTReg but work without
JTRreg as well.
so if test run under JTReg, --no-compile option used and test is
compiled by JTReg it requires both @compile header tag and explicit
compilation code.
Actual changes contains a comment explaining it.
_testclasses variable points to ${TESTCLASSES} under JTreg or
to `pwd`/.classes directory common for all my tests, if run standalone.
-Dmitry
On 2013-02-06 19:50, Mandy Chung wrote:
>
> On 2/6/2013 2:47 AM, Alan Bateman wrote:
>>
>> diff --git a/test/sun/management/jdp/JdpTest.sh
>> b/test/sun/management/jdp/JdpTest.sh
>> --- a/test/sun/management/jdp/JdpTest.sh
>> +++ b/test/sun/management/jdp/JdpTest.sh
>> @@ -23,7 +23,7 @@
>>
>> # @test
>> # @bug 7169888
>> -# @build JdpUnitTest JdpClient JdpDoSomething
>> +# @compile -XDignore.symbol.file JdpUnitTest.java JdpClient.java
>> JdpDoSomething.java
>> # @run shell JdpTest.sh --jtreg --no-compile
>> # @summary No word Failed expected in the test output
>>
>> @@ -55,7 +55,7 @@
>> rm -f ${_testclasses}/*.class
>>
>> # Compile testcase
>> - ${TESTJAVA}/bin/javac -d ${_testclasses} JdpUnitTest.java \
>> + ${COMPILEJAVA}/bin/javac -XDignore.symbol.file -d ${_testclasses}
>> JdpUnitTest.java \
>> JdpDoSomething.java \
>> JdpClient.java
>
> The fix itself looks good. This question is more for the original test:
> Is @compile line needed? Is $_testclasses same as $TESTCLASSES?
>
> Mandy
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
