Thanks. Still good! /Staffan
On 21 feb 2013, at 14:09, Erik Helin <erik.he...@oracle.com> wrote: > Staffan, > > On 02/21/2013 12:22 PM, Staffan Larsen wrote: >> All of these changes look good to me. What I didn't realize at first what >> the change from PermStat.java to ClassLoaderStats.java was simply a name >> change - no code was changed. > > I've update the changes to take this into account. > > On 02/21/2013 12:22 PM, Staffan Larsen wrote: >> The 8005116 bug says that the new option should be -classstats, but the >> code uses -clstats. I think this is better, but you may want to update the >> bug. > > Agree, I've updated the bug. > > Thanks, > Erik > >> Thanks, >> /Staffan >> >> On 20 feb 2013, at 17:01, Erik Helin <erik.he...@oracle.com> wrote: >> >>> Hi all, >>> >>> this change is the first of three changes related to renaming the jmap >>> option permstat to clstats. The change has to be done as three separate >>> changes in order to not break any repositories: >>> 1. Add support for the -clstats option to the SA agent >>> 2. Change the tool jmap to use -clstats instead of -permstat >>> 3. Remove the option -permstat from the SA agent >>> >>> This CR represents the first step. Once this change has found its way into >>> the tl forest, then step two can be applied. Once the result of step two is >>> back in the hotspot-gc forest, then step three can be done. >>> >>> Step 2 and 3 are also out for review. >>> >>> Webrev: >>> http://cr.openjdk.java.net/~ehelin/8008536/webrev.00/ >>> >>> Bug: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008536 >>> >>> Testing: >>> JPRT >>> >>> Thanks, >>> Erik >> >
