Nice catch.
Looks good.
Thanks,
Serguei
On 2/21/13 9:09 PM, Coleen Phillimore wrote:
I'm sorry about this but I need one more review. I omitted one
instance of JVM_CONSTANT_Object in templateTable_sparc.cpp and I
forgot that you can't make any edit to the VM without making a
duplicate edit to the serviceability agent.
open webrev at http://cr.openjdk.java.net/~coleenp/8000797_3/
Reran runThese jcks and sajdi and mlvm tests on solaris/sparc.
Thanks,
Coleen
On 2/21/2013 6:22 PM, John Rose wrote:
On Feb 20, 2013, at 8:11 PM, Coleen Phillimore
<coleen.phillim...@oracle.com <mailto:coleen.phillim...@oracle.com>>
wrote:
Thanks to John's feedback, I've modified this change again to revert
back to my original change to zero out the Symbol* to indicate
pseudo string (could be thought of as "patched string"). Also
cleaned up unused constant pool Object constant and unused flags.
Reran all the tests.
http://cr.openjdk.java.net/~coleenp/8000797_2/
<http://cr.openjdk.java.net/%7Ecoleenp/8000797_2/>
Good; lots of nice deletions. You can use me as a reviewer. — John
