Thanks Kris! Yeah, it would be a nice project to build a full-fledged debugger, but very hard to justify the resources spent :-) I think instead we should view SA as a great tool to dig out JVM-specific data from a process/core - the things a normal debugger knows nothing about.
/Staffan On 22 feb 2013, at 10:27, Krystal Mo <krystal...@oracle.com> wrote: > Hi Staffan, > > Looks good to me (not a Reviewer). > > I had a slight hope in that someday we'll be able to morph Serviceability > Agent into what it was meant to be -- a full-fledged mixed-mode debugger for > HotSpot. > But with the current resources available, I guess we'll just have to accept > that it's not going to happen... So I'm alright with this change. > > Thanks, > Kris > > On 2013/2/21 7:38, Staffan Larsen wrote: >> Please review the following change to remove the BugSpot UI for the >> Serviceability Agent. My understanding is that BugSpot was intended as a >> more general native debugger not only focused on the JVM, but that it was >> never fully implemented. I don't think there is a need for a general-purpose >> debugger in SA and would like to clean up the code. One effect of this >> change is that PStack and PMap will no longer be able to operate on >> executables other than the JVM. >> >> This change was first proposed last year in this thread: >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-April/005811.html >> >> This change also removes some old JVMDI code in SA (JVMDI is no longer >> supported in HotSpot). >> >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7165259 >> >> webrev: http://cr.openjdk.java.net/~sla/7165259/webrev.00/ >> >> >> Thanks, >> /Staffan >