Only reviewed the event metadata (trace.xml), but it look good! I'm not
a Reviewer.
Erik
Jesper Wilhelmsson skrev 2/25/13 1:53 PM:
Hi,
I'm looking for a couple of reviews for the promotion failed tracing
event, now implemented for ParNew and Serial GC.
I have replaced the existing counters and booleans with a
PromotionFailedInfo object and uses that throughout, so now promotion
failed reporting (through the tracing framework) looks the same and
reports the same data for all young collectors.
I have added two new fields to the promotion failed event: firstSize
as reported by ParNew logging, and smallestSize which is the smallest
object size that failed to promote.
Webrew: http://cr.openjdk.java.net/~jwilhelm/8008790
Testing: Passes JPRT and the existing promotion failed tests with all
collectors.
Thanks,
/Jesper
