Looks good!
/Staffan
On 25 mar 2013, at 22:17, Erik Gahlin <erik.gah...@oracle.com> wrote:
> Hi,
>
> Could you please review these small metadata changes for the event tracing
> framework:
>
> - Promotion Failed -> objectCount has the datatype BYTES64, which implies
> that it is a size. It is not, and the type should be an unsigned long.
>
> - Thread Park, Java Monitor Enter and Java Monitor wait should have
> relational ids, so it's possible to see that the information is related
> ("java/monitor/address")
>
> - The field "caller" in ExecuteVMOperation should not have a TO field but a
> FROM field, indicating from which thread the "transition" came from.
>
> The reason the review for 8007150 is handled seperately is because it
> modifies the structure of the data, while these changes are strictly
> cosmetical.
>
> http://cr.openjdk.java.net/~egahlin/8008391_1/
>
> Thanks
> Erik
