On 3/26/13 4:11 PM, Coleen Phillimore wrote:
Summary: Neglected to copy the annotations in clone_with_new_data when they were moved to ConstMethod.

open webrev at http://cr.openjdk.java.net/~coleenp/8009531/

Thumbs up! Only a comment suggestion and a naming heckle :-)

src/share/vm/oops/constMethod.cpp
    One line comment on the function:
    // copy annotations from 'cm' to 'this'

src/share/vm/oops/constMethod.hpp
    Perhaps I've been reading too much Java code lately, but
    seemed like the function should be name 'copy_annotations_from()

src/share/vm/oops/method.cpp
    No comments.


bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531

Also. please review JDK test modified to test that this crash is fixed (will check in in two weeks).

open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk

Thanks,
Coleen







Reply via email to