On 16/04/2013 7:38 PM, Rickard Bäckman wrote:
David,

the reason I introduced a new file was that we need the same changes from our 
closed code. Better to have them in one place.

Got it! Hard to join the dots sometimes.

Looks okay to me.

David

/R

On Apr 16, 2013, at 11:34 AM, David Holmes wrote:

Hi Rickard,

On 15/04/2013 8:56 PM, Rickard Bäckman wrote:
Hi all,

can I have a couple of small fixes for this change?
The purpose of the change is to make it easier to write events without having 
to put them inside a #ifdef INCLUDE_TRACE.
The idea is that when INCLUDE_TRACE is false the code should be no-ops.

The webrev: http://cr.openjdk.java.net/~rbackman/8012210/

Do you need the separate file? can you not just inline the content in the 
original file?

David

Thanks
/R


Reply via email to