Updated webrev:
http://cr.openjdk.java.net/~nloodin/8014048/webrev.03/src/
On 05/15/2013 01:26 AM, Mandy Chung wrote:
On 5/14/13 4:20 AM, Nils Loodin wrote:
Mandy: Is the current relased saved somewhere accessible in the jdk
It's stored in "java.version" property but it requires parsing to
extract the major release number. The private API
sun.misc.Version.getMajorVersion returns that.
or is that something you suggest also be stored in the
message.properties-files?
Not the release version number.
The user guide used to be localized but I only see the English version
of jdk 7 though:
http://www.oracle.com/technetwork/java/javase/documentation/api-jsp-136079.html
Yes, only found the english one, so I haven't used a separate url in
Anyway, it's minor and no big deal. What you have is fine and it's a fix
for jdk7u but you need to replace 's/7/8' for jdk8 code base.
These docs aren't up yet though, but I guess I'll check it in and
eventually the docs will be there.
Regards
Nils Loodin
Mandy
In that case it doesn't seem like we're gaining much, since that would
have to be updated between releaes...
Erik Gahlin also pointed out that the JConsoleResources*.java-files
are stale artefacts that can be safely removed since the messages are
stored in the messages*.properties-files, so that alleviates some of
the pain of storing the strings everywhere.
Here's an updated webrev:
http://cr.openjdk.java.net/~nloodin/8014048/webrev.01/
Regards,
Nils Loodin
/Staffan
On 13 maj 2013, at 15:36, Nils Loodin<[email protected]> wrote:
On 05/13/2013 03:36 PM, Nils Loodin wrote:
Simple change of link in resource files:
https://jbs.oracle.com/bugs/browse/JDK-8014048
Regards,
Nils Loodin
Also, with webrev link (might come in handy):
http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/
