Looks good to me too except the indentation as Staffan pointed out (line 458-459)
Mandy

On 5/27/2013 7:47 AM, Daniel D. Daugherty wrote:
Sure! Chime!!!

> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/

src/share/classes/sun/tools/jconsole/VMPanel.java
    No comments (presuming you fix the indentation on lines 458-459)

Thumbs up!

FYI: Mandy Chung is the person to ping if/when you have a more
complicated jconsole fix...

Dan



On 5/27/13 8:34 AM, Nils Loodin wrote:
Could you please chime in? :)

/Nisse

On 05/24/2013 06:33 PM, Staffan Larsen wrote:
Looks good, but the indentation is wrong in one place.

/Staffan

On 24 maj 2013, at 16:13, Nils Loodin <nils.loo...@oracle.com> wrote:

Simple fix not to add a confusing dialog.

Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730

Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/

Regards,
Nils Loodin




Reply via email to