Looking good to me. /peter
----- Original Message ----- From: nils.loo...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Tuesday, May 28, 2013 10:36:20 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Looks good. /Nisse On 05/28/2013 10:11 AM, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 > > The problem is that serial gc does not compact the heap at every full gc but > only every 4th full gc (by default). When the heap isn't compacted the > "usage" is returned as a higher-than-expect value. This can be changed with > -XX:MarkSweepAlwaysCompactCount=1. > > Testing: I have rerun the test on a machine where it failed to make sure that > it runs correctly with the extra flag. > > Thanks, > /Staffan >