On 28 maj 2013, at 10:34, Bengt Rutisson <bengt.rutis...@oracle.com> wrote:
> > Staffan, > > Looks good. > > One minor question: > > Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount > into the existing comment section rather than adding a new section for it? I > think it might increase the chances that someone reads the comment if it is > closer to the @run command. Yeah, I wanted it right before the @run tag, but jtreg got all confused so I moved it to a separate section. /Staffan > > Not an important thing to fix. I'll leave it up to you how to do it. > > Thanks, > Bengt > > On 5/28/13 10:11 AM, Staffan Larsen wrote: >> Please review the following fix: >> >> webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 >> >> The problem is that serial gc does not compact the heap at every full gc but >> only every 4th full gc (by default). When the heap isn't compacted the >> "usage" is returned as a higher-than-expect value. This can be changed with >> -XX:MarkSweepAlwaysCompactCount=1. >> >> Testing: I have rerun the test on a machine where it failed to make sure >> that it runs correctly with the extra flag. >> >> Thanks, >> /Staffan >
