On 4/06/2013 10:57 PM, Dmitry Samersoff wrote:
David,
Fixed comments.
Thanks.
David
-Dmitry
On 2013-06-04 16:13, David Holmes wrote:
On 4/06/2013 7:50 PM, Dmitry Samersoff wrote:
Staffan,
Two bytes len prefix is a part of JDP protocol specification, so I would
prefer to write it explicitly.
But changed to *writeUTF()* as recommended.
see: http://cr.openjdk.java.net/~dsamersoff/8015604/webrev.02/
The new comment doesn't make sense as there is no 'b' any more.
David
-Dmitry
On 2013-06-04 11:48, Staffan Larsen wrote:
Looks good.
Even better would have been to use DataOutputStream.writeUTF().
/Staffan
On 3 jun 2013, at 23:33, Dmitry Samersoff
<dmitry.samers...@oracle.com> wrote:
Hi Everybody,
The problem:
Code uses string length rather than byte array length to write length
field of JDP packet entry. So if an entry contains non-ASCII characters
code produces invalid packet.
http://cr.openjdk.java.net/~dsamersoff/8015604/webrev.01/
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
