Hi Dmitry, This looks reasonable to me.
You should probably log an RFE on javax.management, to make RelationNotification override setSource() and throw IAE when source is null, so that the behavior of setSource is consistent with the constructor. That would be a spec change - but maybe it's something that could be included in the next JMX Maintenance Review, if there is one. best regards, -- daniel On 7/2/13 7:52 PM, Dmitry Samersoff wrote:
Hi Everybody, *problem* Despite the fact, that validation in constructor of RelationNotification prohibit creation of the class instance with null sourceObj its possible to set it to null later by public setSource() method. So we should relax validation rules to preserve serialization behavior compatibility. *webrev* http://cr.openjdk.java.net/~dsamersoff/8011038/webrev.01/ *testing* JCK, no separate regression tests required.
