Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

[Daniel D. Daugherty]

On 7/16/13 9:48 AM, Markus Grönlund wrote:

Greetings,

Kindly asking for reviews for the following change in hsx24:

Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547

Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/ <http://cr.openjdk.java.net/%7Emgronlun/8020547/webrev01/>

src/share/vm/trace/traceDataTypes.hpp
    No comments.

src/share/vm/trace/tracetypes.xml
    line 277: type="TraceUnicodeString*" sizeop="sizeof_unicode(%)"/>

        The pointer type above and below this one have a space
        between the type name and the '*'. Any particular reason
        for the difference?

src/share/vm/trace/xinclude.mod
    This one threw me for a second when I was just looking at the
    patch. In the frames version, it is clear that you're removing
    an extra copyright block...

Thumbs up!

Dan

tracetypes.xml will declare a STRING type in order to support larger strings compared to existing UTF8 type (which is limited to a length of u2, max 65535 chars).

I have also removed some stale comments.

Thank you

Markus