Looks good.

/Staffan

On 12 aug 2013, at 14:51, Peter Allwin <peter.all...@oracle.com> wrote:

> Hello!
> 
> This patch addresses several Nashorn compatibility issues with in sa.js and 
> is a merge of my patch [0] and Kris' (kmo) [1] which were developed 
> separately.
> 
> The merged change is identical to [1] with except for line 785 where I've 
> added a conversion to JavaScript String to ensure the correct replace method 
> is called.
> 
> 
> webrev: http://cr.openjdk.java.net/~allwin/8011888/webrev.01/
> bug: http://bugs.sun.com/view_bug.do?bug_id=8011888
> 
> 
> Thanks!
> /Peter
> 
> 
> [0] http://cr.openjdk.java.net/~allwin/8011888/webrev.00/
> [1] 
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html
> 

Reply via email to