Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

[David Holmes]

Hi Serguei,

This is more consistent with the surrounding code, but:
1. Why no RC_TRACE_WITH_THREAD for this case?

2. If an exception is pending, that isn't OOME, shouldn't "res" already 
not be JVMTI_ERROR_NONE and so res should be returned in the non-OOME case?

David

On 12/09/2013 8:13 AM, serguei.spit...@oracle.com wrote:

Please, review the fix for:
   bug: http://bugs.sun.com/view_bug.do?bug_id=8024346
   jbs: https://bugs.openjdk.java.net/browse/JDK-8024346


Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.1


Summary:
   Pending exceptions must be handled properly after a call to the JVMTI
merge_cp_and_rewrite.



Testing:
   UTE tests - in progress:  vm.quick-pcl.testlist with limited
Metaspace memory,
                                         nsk.jvmti.testlist,
nsk.jdi.testlist,
                                         Jtreg java/lang/instrument

Thanks,
Serguei