Reviewed-by: emcmanus The order of the parameters in checkMutableReference and checkReturnMutables is surprising, but otherwise this looks good.
Éamonn 2013/9/26 Jaroslav Bachorik <jaroslav.bacho...@oracle.com> > I've updated the webrev to utilize "readResolve" method to clone the > deserialized instance before returning it - as recommended by Eamonn. This > way it is possible to keep all the fields final while imposing imutability > during the deserialization. > > The update webrev is at http://cr.openjdk.java.net/~** > jbachorik/8002307/webrev.04<http://cr.openjdk.java.net/~jbachorik/8002307/webrev.04> > > -JB- > > > On 4.9.2013 09:16, Jaroslav Bachorik wrote: > >> [ping] >> >> Thanks for the reviews. I still need a reviewer to take a look at this. >> This issue blocks a P2 targeted for JDK8 (JDK-7148504). >> >> Thanks, >> >> -JB- >> >> On 07/18/2013 11:54 AM, Jaroslav Bachorik wrote: >> >>> Hi, >>> >>> thanks for the comments. >>> >>> Here >>> (http://cr.openjdk.java.net/~**jbachorik/8002307/webrev.03/<http://cr.openjdk.java.net/~jbachorik/8002307/webrev.03/>) >>> is the >>> updated webrev implementing suggestions from Daniel and Shanliang. >>> >>> -JB- >>> >>> >>> >> >
