The new version looks good to me.
Thanks Shanliang!
-- daniel
On 9/24/13 1:22 PM, shanliang wrote:
Daniel Fuchs wrote:
On 9/23/13 8:27 PM, shanliang wrote:
Hi,
Please review this test fix, if the test continues failing, then we need
to investigate the Monitor implementation.
webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025207/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8025207
Thanks,
Shanliang
Hi Shanliang,
There seems to an issue in the exit condition of the loop in the
new code.
The old code had:
150 if (derivedGaugeValue.intValue() != derivedGauge[i])
the new code has:
155 } while (derivedGaugeValue.intValue() != counter[i]);
Good catch, I changed the code, even they are same today:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8025207/01/
Also I'm not sure it's good idea to make a println every 100ms...
OK, removed, in some case is useful, but ...
Thanks,
Shanliang
-- daniel
