Looks good! Thanks, /Staffan
On 20 sep 2013, at 16:29, Fredrik Arvidsson <[email protected]> wrote: > Please help me review this: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8016845 > Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8016845/webrev.00/ > <http://cr.openjdk.java.net/%7Eallwin/farvidss/8016845/webrev.00/> > > Small change was made in the sa.make file for windows to compile and link > sadis.c in to sawindbg.dll providing JNI entrypoints needed to call the hsdis > disassembler from SADB on windows. A small change in > agent/src/share/classes/sun/jvm/hotspot/asm/Disassembler.java to have the > correct library name when loading library depending if running on 32 or 64 > bit platform. > > To test this you have to build the hsdis library yourself, since it cant be > bundled due to license issues. Instructions can be found here: > http://dropzone.nfshost.com/hsdis.htm (hint, I have pre-built binaries). When > running disassembling in HSDB (using the 'dis' command in the console) the > hsdis-amd64.dll/hsdis-i386.dll must be in the /bin directory of the JRE/JDK > used. > > Cheers > /Fredrik
