On 2.10.2013 16:11, Dmitry Samersoff wrote:
Jaroslav,

As a far as loopback address could be resolved to any of 127.0.0.0/8
client and server have to use the same loopback address.

AFAIK, all the IPs 127.*.*.* equally designate the loopback interface. This might start breaking when you have more than one loopback interface in the system. But all of this might be irrelevant here - the IPs are retrieved *after* the JMX connection has been established making it clear that they are reachable.


Generally speaking it's not required for 127.0.1.1 to be able to talk to
127.0.0.1 and we are in risk to get a weird fail instead of clear error
message.

As I said before as long as there is only one loopback interface it is safe to assume that all the loopback IPs are virtually identical. When we start considering multiple loopback interfaces we would need to take into account the also the assigned network interfaces.

But it might hardly matter - it seems that the main culprit for this test to fail on this particular configuration was the fact that 127.0.0.1 was *NOT* detected as a loopback IP. This is pretty weird and makes one question the sanity of the test setup...

-JB-


-Dmitry


On 2013-09-11 18:51, Jaroslav Bachorik wrote:
Please, review this simple patch for an intermittently failing test.

The test fails in cases when the connection loopback is resolved to be
127.0.1.1 - it may happen under certain circumstances in eg. Ubuntu. The
test does not anticipate this possibility and requires the loopback
address to be exactly 127.0.0.1

The test will end comparing 127.0.0.1 against 127.0.1.1 and will
consider them non equal even though they are both the same loopback. The
patch adds a bit of flexibility to the test allowing for any two valid
loopback addresses (127.0.0.0/8) to be equal.

Issue  : JDK-8022220
Webrev : http://cr.openjdk.java.net/~jbachorik/8022220/webrev.00

Thanks,

-JB-




Reply via email to