Thanks John, I didn't realize that I forgot static keyword on the
normalize function and I like the suggestion to move it to constantTag
even better. Unfortunately, I've already checked it in. I'll make this
cleanup with my next (related) bug fix.
Thanks,
Coleen
On 10/10/2013 12:15 AM, John Rose wrote:
Looks good.
Suggestion: Make normalize_error_tag be static, for namespace cleanliness.
Even better, move it into constantTag, as (say) constantTag::non_error_value().
— John
On Oct 9, 2013, at 7:04 PM, Coleen Phillimore <[email protected]>
wrote:
Thanks Dan!
Coleen
On 10/9/2013 6:39 PM, Daniel D. Daugherty wrote:
On 10/8/13 12:27 PM, Coleen Phillimore wrote:
Summary: Add missing cases.
I verified this with the test for
https://bugs.openjdk.java.net/browse/JDK-8022701 but don't want to copy the
test into with modifications the hotspot repository, still working on
refactoring the test for the JDK repository for after this gets pushed.
open webrev at http://cr.openjdk.java.net/~coleenp/8025185/
src/share/vm/oops/constantPool.cpp
No comments.
Thumbs up.
Dan
bug link https://bugs.openjdk.java.net/browse/JDK-8025185
Thanks,
Coleen
