On 16.10.2013 10:06, Yekaterina Kantserova wrote:
Hi David,
Thank you for your comments!
You have right, it's worth to check testlibrary changes twice. For
example Erik Helin has pointed out to me there already is Asserts.java
in hotspot/testlibrary. I don't mind to merge hotspot testlibrary into jdk.
This is already tracked by JDK-8015497. It would be nice to have one
shared testlibrary, though.
-JB-
Thanks,
Katja
On 10/16/2013 06:06 AM, David Holmes wrote:
Hi Katja,
Not a review just a couple of meta comments.
First I've added hotspto-dev as all these changes to the test library
need a wider review audience. I'm a little concerned about its current
rate of expansion.
Second all the new files have the wrong copyright notice - they should
have the OpenJDK copyright.
Thanks,
David
On 15/10/2013 11:35 PM, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
The purpose of this fix is to get rid of intermittent failures in
sun/tools/jstatd tests and make the tests more stable, legible and
maintainable.
Thanks,
Katja
Webrev:
http://cr.openjdk.java.net/~ykantser/8022229/webrev.00/
Primal bug:
https://bugs.openjdk.java.net/browse/JDK-8022229
Similar bugs:
https://bugs.openjdk.java.net/browse/JDK-8019630
https://bugs.openjdk.java.net/browse/JDK-6636094
https://bugs.openjdk.java.net/browse/JDK-6543979
