Still looking for an official Review of this change. Thanks, /Staffan
On 11 Nov 2013, at 10:32, Staffan Larsen <staffan.lar...@oracle.com> wrote: > Thanks Serguei! > > Can I have an official Review as well? > > /Staffan > > On 04 Nov 2013, at 21:08, serguei.spit...@oracle.com wrote: > >> Staffan, >> >> This one is really old: 11+ years. :) >> The fix is good, I do not see any issues. >> >> Thanks, >> Serguei >> >> >> On 11/4/13 6:41 AM, Staffan Larsen wrote: >>> This is an old one! Nothing like being bored on a plane... >>> >>> The problem here was that the expression evaluator in jdb did not handle >>> numbers larger than Integer.MAX_VALUE. When necessary these need to be >>> converted to longs instead of ints. >>> >>> While I was touching the code, I added support for the unary operations: -, >>> +, ~ and ! (did I mention I was bored). >>> >>> There are many files changed in the webrev, but I've actually only touched >>> three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by >>> javacc. The generated files have lost their copyright headers. If needed, I >>> can add those back before pushing the change, but since it's manual work I >>> want to do it after the review is done. >>> >>> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-4660158 >>> >>> Thanks, >>> /Staffan >> >
