Thanks, Jaroslav.

I’ll fix the “else” before pushing.

/Staffan

On 17 dec 2013, at 15:27, Jaroslav Bachorik <[email protected]> 
wrote:

> Looks good (not-a-reviewer).
> One very minor nit - CheckOrigin.java#79 "else" is on a separate line; this 
> does not seem to be the formatting used throughout the jdk sources.
> 
> -JB-
> 
> On 17.12.2013 15:09, Staffan Larsen wrote:
>> When getting the origin of a VMOption through the mbean, the 
>> ATTACH_ON_DEMAND origin is missing.
>> 
>> This required changes both to hotspot and libs. I will push the hotspot 
>> changes first (to hs-rt) and later the libs+test changes (to dev).
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8028994/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8028994
>> 
>> Thanks,
>> /Staffan
>> 
> 

Reply via email to