Thank you for reviewing this!
Unfortunantely I can't use Basic.java since we don't use packages for
jtreg tests.
Should I use "2005 - 2014" instead of "2005, 2011, 2014"?
Thanks,
Katja
On 01/13/2014 12:33 PM, Alan Bateman wrote:
On 13/01/2014 10:40, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
I've rewritten the shell tests sun/tools/jstack and sun/tools/jmap in
pure Java to get rid of environmental problems. The
com/sun/tools/attach tests has already been fixed.
Webrev:
http://cr.openjdk.java.net/~ykantser/6380601/webrev.00/
Bug:
https://bugs.openjdk.java.net/browse/JDK-6380601
A minor comment but the location implies that it is a test for jmap or
jstack so you could use a shorter name for the test if you wish. In
other areas then we have been using "Basic.java" for the name of basic
tests.
You might want to check the copyright dates, there should be one year
or a range (two years) rather than three.
-Alan
