Staffan, On 2014-01-22 17:30, Staffan Larsen wrote: > Looks good! > > Should we perhaps add the output of ‘ls -l $HOME/jdb.ini’ when it fails?
I would prefer not to load test with diagnostic code (actually, check for root is also redundant). There are plenty of reason for file to being readable and we can't check it all without significant efforts. -Dmitry > > Thanks, > /Staffan > > > On 22 jan 2014, at 14:18, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > >> Staffan, >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.02/ >> >> Updated webrev - test will continue fail but with meaningful diagnostic. >> >> -Dmitry >> >> On 2014-01-21 18:49, Staffan Larsen wrote: >>> Should we really be skipping the test if this fail? Isn’t it an >>> infrastructure bug if we can’t make the file unreadable? I think the test >>> should fail, but say why it failed: “could not make $HOME/jdb.ini >>> unreadable” and perhaps include the current permissions on the file and >>> directory for debugging purposes. >>> >>> /Staffan >>> >>> On 21 jan 2014, at 15:00, Dmitry Samersoff <dmitry.samers...@oracle.com> >>> wrote: >>> >>>> Missed CR in subject. Sorry! >>>> >>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.01/ >>>> >>>> >>>> On 2014-01-21 17:49, Dmitry Samersoff wrote: >>>>> Hi Everyone, >>>>> >>>>> Please review. >>>>> >>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.01/ >>>>> >>>>> I can't reproduce the issue locally, but suspect, the test failed >>>>> because after chmod a-r the file is sill readable. So check it >>>>> explicitly before run the test itself. >>>>> >>>> >>>> >>>> -- >>>> Dmitry Samersoff >>>> Oracle Java development team, Saint Petersburg, Russia >>>> * I would love to change the world, but they won't give me the sources. >>> >> >> >> -- >> Dmitry Samersoff >> Oracle Java development team, Saint Petersburg, Russia >> * I would love to change the world, but they won't give me the sources. > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
